Install correct version with brew. Fixes #1088 #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nope. Branch mvnd-1.x produces 1.x (Maven 3.9.x) versions while master produces 2.x (Maven 4.x) versions. |
gnodet
reviewed
Aug 14, 2024
| @@ -63,7 +63,7 @@ sense. With SDKMAN!, the `~/.m2/mvnd.properties` file is typically not needed at | |||
|
|
|||
| [source,shell] | |||
| ---- | |||
| $ brew install mvndaemon/homebrew-mvnd/mvnd | |||
| $ brew install mvndaemon/homebrew-mvnd/mvnd@1 | |||
There was a problem hiding this comment.
This PR should target mvnd-1.x branch and not master.
There was a problem hiding this comment.
I'm targeting the README file that appears when you got to the repository. That would the master branch. Should the master branch have instructions that install the pre-release version?
Also, MVND is awesome.
There was a problem hiding this comment.
Well, maybe provide instructions for both then ? and add a comment to explain what that there are two branches.
gnodet
requested changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.